-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
Please coordinate with #35986. |
This seems reasonable to me (one the presubmits are fixed). @cbracken, do you have reservations about this approach? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I've applied a small formatting fix that should get CI to pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit and a question. Looks like main will need to be merged in again for CI.
I just updated branch with changes (+ integrated formatting fix in concerned commit). |
Fixed issue with android build (from windows), and rebased on top of main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-lgtm! Thanks!
Linaro [Windows on Arm](https://www.linaro.org/windows-on-arm/) team is working to enable projects for this new platform. Lately, we have been interested in Dart/Flutter. This PR enables building natively flutter components (exe + dll) for windows on arm. It solves this issue (flutter/flutter#62597) partially, by starting with native build.
Linaro Windows on Arm team is working to enable projects for this new platform.
Lately, we have been interested in Dart/Flutter.
This PR enables building natively flutter components (exe + dll) for windows on arm.
It solves this issue (flutter/flutter#62597) partially, by starting with native build.
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.