Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

pbo-linaro
Copy link
Contributor

Linaro Windows on Arm team is working to enable projects for this new platform.
Lately, we have been interested in Dart/Flutter.

This PR enables building natively flutter components (exe + dll) for windows on arm.

It solves this issue (flutter/flutter#62597) partially, by starting with native build.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@zanderso
Copy link
Member

zanderso commented Sep 8, 2022

Please coordinate with #35986.

@pbo-linaro
Copy link
Contributor Author

@zanderso: Could you please merge first #35986, and I'll rebase that one?

Normally it will just simplify current PR, by changing one of its commit.

@chinmaygarde
Copy link
Member

This seems reasonable to me (one the presubmits are fixed). @cbracken, do you have reservations about this approach?

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I've applied a small formatting fix that should get CI to pass.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit and a question. Looks like main will need to be merged in again for CI.

@pbo-linaro
Copy link
Contributor Author

pbo-linaro commented Sep 21, 2022

I just updated branch with changes (+ integrated formatting fix in concerned commit).

@pbo-linaro
Copy link
Contributor Author

Fixed issue with android build (from windows), and rebased on top of main.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-lgtm! Thanks!

@cbracken cbracken merged commit 25641d1 into flutter:main Sep 22, 2022
@pbo-linaro pbo-linaro deleted the woa_build branch September 23, 2022 07:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 23, 2022
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
Linaro [Windows on Arm](https://www.linaro.org/windows-on-arm/) team is working to enable projects for this new platform.
Lately, we have been interested in Dart/Flutter.

This PR enables building natively flutter components (exe + dll) for windows on arm.

It solves this issue (flutter/flutter#62597) partially, by starting with native build.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants