Enable analysis for all of dart:ui #34988
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -47,8 +46,7 @@ echo "Using dart from $DART_BIN" | |||
| "$DART" --version | |||
| echo "" | |||
|
|
|||
| (cd $SKY_ENGINE_DIR && "$DART" pub get --offline) | |||
| "$DART" analyze "$SKY_ENGINE_DIR/lib/ui/ui.dart" | |||
| "$DART" analyze "$FLUTTER_DIR/lib/ui" | |||
There was a problem hiding this comment.
Talked about this offline - there's a slight risk that this will miss things the build rules do e.g. with _embedder.yaml, but it seems to be working fine and it's what we used to do.
If we ever discover we really need to analyze the build output instead of the input, we can copy analysis_options over to the root_gen_dir and it should probably work, but that may get broken more easily or confusing.
|
test-exempt: is a test |
Analysis for all of
dart:uiwas accidentally disabled about a year ago in #28208. After that change, onlyui.dartwas analyzed (ignoring all other files that make updart:ui) and it was analyzed with the default analysis options ignoring our customanalysis_options.yaml.This change re-enables analysis for all of
dart:uiusing our customanalysis_options.yamlfile and fixes the issues that have been introduced since then.