Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

jason-simmons
Copy link
Member

Also migrates to the HarfBuzz 3.x font subsetting API
(see #29266)

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Contributor

dnfield commented Dec 15, 2021

License bot is not happy

@jason-simmons jason-simmons force-pushed the roll_harfbuzz_121521 branch 4 times, most recently from 23f2cfe to 0b2e083 Compare December 16, 2021 15:19
Also migrates to the HarfBuzz 3.x font subsetting API
(see flutter#29266)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants