This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add FlutterPlayStoreSplitApplication to v2 embedding #29241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
cc @camsim99 FYI, part of things needed to begin deprecation of v1 embedding |
blasten
reviewed
Oct 21, 2021
| * }</pre> | ||
| * | ||
| * This class is meant to be used with the Google Play store. Custom non-play store applications do | ||
| * not need to extend SplitCompatApplication and should inject a custom {@link |
blasten
approved these changes
Oct 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 27, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 27, 2021
This was referenced Oct 27, 2021
Merged
GaryQian
added a commit
to flutter/gallery
that referenced
this pull request
Oct 28, 2021
flutter/engine#29241 moves FlutterPlayStoreSplitApplication to the embedding package as we look to remove the v1 embedding. This updates the manifest to reflect this change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the deprecation of the v1 embedding, this convenience application class should be included/replicated under the v2 embedding as well for deferred components.
In a future PR, we can also use the work done in flutter/#90944 to automatically set the application to include splitcompat.