This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove Robolectric and add androidx.tracing to the android_embedding_dependencies package #29233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
blasten
approved these changes
Oct 18, 2021
xster
reviewed
Oct 18, 2021
| @@ -42,6 +42,7 @@ android { | |||
| dependencies { | |||
| embedding "androidx.annotation:annotation:1.1.0" | |||
| embedding "androidx.fragment:fragment:1.1.0" | |||
| embedding "androidx.tracing:tracing:1.0.0" | |||
There was a problem hiding this comment.
how much size increase are we adding to the engine dex?
There was a problem hiding this comment.
I left a comment: #29230 (comment)
I'd expect this to be tree-shaked until #29230 lands.
There was a problem hiding this comment.
androidx.tracing is tiny - it's a thin wrapper over android.os.Trace with some version checks and backward compatibility workarounds
|
Thanks Jason! I'm not familiar to the build process here - is it right to say that local builds of the engine (that depend on |
|
Yes - you'll need a AndroidX tracing JAR in |
…dependencies package
fb4e66e to
80933a7
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2021
…bedding_dependencies package (flutter/engine#29233)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2021
…bedding_dependencies package (flutter/engine#29233)
kylinchen
pushed a commit
to XianyuTech/engine
that referenced
this pull request
Oct 22, 2021
…dependencies package (flutter#29233)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.