This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] use 'dart compile js' instead of 'dart2js' in web_ui and felt #29179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'dart2js'. This change prepares flutter for an upcoming deprecation of the dart2js script. The compiler will be available going forward from 'dart compile js' instead.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2021
8 tasks
iskakaushik
added a commit
to iskakaushik/flutter
that referenced
this pull request
Oct 15, 2021
Also ignores: flutter#91906 2021-10-15 mouad.debbar@gmail.com [web] Add goldctl as a dependency in LUCI (flutter/engine#29168) 2021-10-15 renyou@google.com Revert "Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility (flutter#29060)" (flutter/engine#29206) 2021-10-15 skia-flutter-autoroll@skia.org Roll Dart SDK from e8c02a935741 to 42acd2ae8fa8 (1 revision) (flutter/engine#29205) 2021-10-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 9f3cd7a49814 to e8c02a935741 (1 revision) (flutter/engine#29204) 2021-10-15 skia-flutter-autoroll@skia.org Roll Skia from 012f7146067a to b24bad31dc05 (3 revisions) (flutter/engine#29203) 2021-10-15 skia-flutter-autoroll@skia.org Roll Skia from 72602b668e22 to 012f7146067a (1 revision) (flutter/engine#29202) 2021-10-15 skia-flutter-autoroll@skia.org Roll Dart SDK from aaca2ac128ae to 9f3cd7a49814 (1 revision) (flutter/engine#29201) 2021-10-15 jason-simmons@users.noreply.github.com Set the use_ios_simulator flag only on platforms where it is defined (iOS/Mac) (flutter/engine#29199) 2021-10-14 akbiggs@users.noreply.github.com [fuchsia] Create CF v2 Flutter runner. (flutter/engine#29142) 2021-10-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 82b0281cbcf3 to aaca2ac128ae (1 revision) (flutter/engine#29198) 2021-10-14 skia-flutter-autoroll@skia.org Roll Skia from aa9656d8caa6 to 72602b668e22 (1 revision) (flutter/engine#29196) 2021-10-14 rileyporter@google.com Ignore implicit_dynamic_function analyzer error for js_util generic methods (flutter/engine#29192) 2021-10-14 sigmund@google.com [web] use 'dart compile js' instead of 'dart2js' in web_ui and felt (flutter/engine#29179) 2021-10-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 081a57c06088 to 82b0281cbcf3 (3 revisions) (flutter/engine#29195) 2021-10-14 skia-flutter-autoroll@skia.org Roll Skia from d0c7f636453b to aa9656d8caa6 (3 revisions) (flutter/engine#29194) 2021-10-14 wyte.sk133@gmail.com Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060) 2021-10-14 koutaro.mo@gmail.com [UWP] Remove 1px offset to make root widget fully shown (flutter/engine#27922) 2021-10-14 skia-flutter-autoroll@skia.org Roll Skia from ab19daec3b88 to d0c7f636453b (1 revision) (flutter/engine#29191) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC kaushikiska@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kylinchen
pushed a commit
to XianyuTech/engine
that referenced
this pull request
Oct 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed in preparation for an upcoming deprecation of the dart2js script. The compiler will be
available going forward from
dart compile jsinstead.