Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fuchsia: Enable ASAN; add tests flag #29414

Merged
merged 3 commits into from
Oct 29, 2021
Merged

fuchsia: Enable ASAN; add tests flag #29414

merged 3 commits into from
Oct 29, 2021

Conversation

arbreng
Copy link
Contributor

@arbreng arbreng commented Oct 29, 2021

Get ASAN builds working on fuchsia so we can use them to catch memory corruption in tests.

Also, gate building the fuchsia tests behind the same enable_unittests flag as other platforms.

Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=87628

@arbreng arbreng requested review from chaselatta and akbiggs October 29, 2021 18:56
@google-cla google-cla bot added the cla: yes label Oct 29, 2021
@arbreng arbreng force-pushed the fuchsia-test-improvements branch 2 times, most recently from 95131dd to 8659170 Compare October 29, 2021 19:38
@arbreng
Copy link
Contributor Author

arbreng commented Oct 29, 2021 •
edited
Loading

I can't gate building tests on the enable-unittests flag quite yet, we need to change infra first to pass that flag when building. Once that's done, I'll push another PR that disables building unit tests by default on fuchsia.

@arbreng arbreng force-pushed the fuchsia-test-improvements branch from 8659170 to c8477d2 Compare October 29, 2021 20:04
akbiggs
akbiggs approved these changes Oct 29, 2021
View reviewed changes
tools/fuchsia/fuchsia_libs.gni
# Note, for clang libs we use the md5 hashes here because of gn limitations of
# json parsing.
# This is a hack, and we can migrate to a better way soon.
common_libs += [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to += these libraries here instead of keeping them as part of the initial definition of common_libs above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are supplied by the clang toolchain, as opposed to the other libraries which are supplied by the fuchsia SDK. So I wanted to break them out

@arbreng arbreng merged commit ba2de77 into flutter:master Oct 29, 2021
@arbreng arbreng deleted the fuchsia-test-improvements branch October 29, 2021 22:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
7a07d47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
ae05532
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
8e27937
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
3c47568
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
24d72ff
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
c7f4d09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
91ed5a3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
07ebdd1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
2214c06
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
63c5b8a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
6d01902
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
20883b4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
44e7336
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
ce0bade
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
43b0867
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
6b9cb07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
51816c6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
249afff
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
a86d0ef
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
a9ff2a7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
ba2de77 fuchsia: Enable ASAN; add tests flag (flutter/engine#29414)
b2f1732
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@chaselatta chaselatta chaselatta approved these changes

@akbiggs akbiggs akbiggs approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
affects: tests cla: yes platform-fuchsia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arbreng @chaselatta @akbiggs