Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Update to match harfbuzz subsetting 3.0.0 api." #29412

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Revert "Update to match harfbuzz subsetting 3.0.0 api." #29412

merged 1 commit into from
Oct 29, 2021
+6 −11

Conversation

xster
Copy link
Member

@xster xster commented Oct 29, 2021

Reverts #29266

breaking Google version dependency b/204512325

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Oct 29, 2021
@xster xster merged commit aeb337a into master Oct 29, 2021
@xster xster deleted the revert-29266-harfbuzz_api_update branch October 29, 2021 19:12
@chinmaygarde
Copy link
Member

Is there a bug tracking re-landing this?

@jason-simmons
Copy link
Member

Filed flutter/flutter#92732

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
ff1d49a 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
2126705 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
85134ba 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
80d8a6f 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
c3e539a 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
6a31a3b 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
d175961 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
af01dd8 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
4b9793e 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
80a1bd8 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
313ae41 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
1e54a08 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
231e6ff 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
b5a66aa 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
8974142 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
df1bb66 
…er#29266)" (flutter/engine#29412)
renyou pushed a commit to renyou/engine that referenced this pull request Oct 31, 2021
@xster @renyou
Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutter#29266)…
5a04e86 
…" (flutter#29412)

This reverts commit 836d265.
renyou added a commit that referenced this pull request Oct 31, 2021
@renyou @xster
Cherry pick a revert on flutter-2.8-candidate.2 to unblock the intern…
615de3c 
…al roll. (#29427)

* Revert "Update to match harfbuzz subsetting 3.0.0 api. (#29266)" (#29412)

This reverts commit 836d265.

* Fix typo in ci.yaml

Co-authored-by: xster <xster@google.com>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
72b167b 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
675f8b2 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
4e61282 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
e044507 
…er#29266)" (flutter/engine#29412)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
aeb337a Revert "Update to match harfbuzz subsetting 3.0.0 api. (flutt…
571b09e 
…er#29266)" (flutter/engine#29412)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes needs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xster @chinmaygarde @jason-simmons