Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 14, 2021

This changes the availability of the edge to edge ui mode based on customer feedback. Not all of the necessary api to configure the style is available until 29, when it was actually first recommended.

Fixes b/199406748 internally
Fixes flutter/flutter#89774

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Edge to Edge should only be offered at a higher API
2 participants