Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fixes Edge trigger route change announcement #21975

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Fixes Edge trigger route change announcement #21975

merged 3 commits into from
Oct 22, 2020

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Oct 19, 2020 •
edited
Loading

Description

According to this doc https://docs.google.com/document/d/1EnsBkScApwOCFgXjb4_Zj3MR0izQxWUi2x3m0ceJ0Yg/edit#

There are some mismatch between the code and the design doc

  1. iOS does not correctly find the last route that is in the new route list but not in the previous route list.
  2. iOS does not consider the case where a route is removed in the middle.
  3. android does not consider the case where a route is removed in the middle.

Related Issues

Fixes flutter/flutter#66308

Tests

I added the following tests:

see files

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@google-cla google-cla bot added the cla: yes label Oct 19, 2020
@jonahwilliams
Copy link
Contributor

When removing routes from the middle, what does the bridge announce now?

@chunhtai
Copy link
Contributor Author

When removing routes from the middle, what does the bridge announce now?

the last route in the newRoutes

jonahwilliams
jonahwilliams approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Oct 20, 2020
@fluttergithubbot fluttergithubbot merged commit aed8e01 into flutter:master Oct 22, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 23, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2020
@engine-flutter-autoroll
aed8e01 Fixes Edge trigger route change announcement (flutter/engine#…
b5d5a9d 
…21975)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 23, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2020
@engine-flutter-autoroll
aed8e01 Fixes Edge trigger route change announcement (flutter/engine#…
0b112e1 
…21975)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 23, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2020
@engine-flutter-autoroll
aed8e01 Fixes Edge trigger route change announcement (flutter/engine#…
cdfc8a2 
…21975)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 23, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2020
@engine-flutter-autoroll
aed8e01 Fixes Edge trigger route change announcement (flutter/engine#…
98c533a 
…21975)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 23, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2020
@engine-flutter-autoroll
aed8e01 Fixes Edge trigger route change announcement (flutter/engine#…
5eff3e5 
…21975)
zanderso pushed a commit to flutter/flutter that referenced this pull request Oct 23, 2020
@engine-flutter-autoroll
Roll Engine from defa8be to 0b26570 (21 revisions) (#68897)
ec0a757 
* 000bf4b Roll Skia from 2d2f82c00aeb to 5c7bb326a7b3 (33 revisions) (flutter/engine#22059)

* ae92dbf Roll Fuchsia Linux SDK from lPMs_KwnU... to gqS_DIjN4... (flutter/engine#22057)

* 92cd74e Roll Fuchsia Mac SDK from pZ9FgVZTK... to WLxBkBnZa... (flutter/engine#22055)

* e51c710 Roll Dart SDK from a3d902d8598e to 9f907e198970 (2 revisions) (flutter/engine#22058)

* 326b202 Reland fuchsia external view embedder will be shared with platform view (flutter/engine#22008)

* a9a9a2f Roll Skia from 5c7bb326a7b3 to 65674e4c2e56 (3 revisions) (flutter/engine#22060)

* 1233fe4 Revert "Revert "Explicitly make the X connection for EGL. (#21831)" (#21851)" (flutter/engine#21871)

* aed8e01 Fixes Edge trigger route change announcement (flutter/engine#21975)

* 6bc70e4 Reland: Migration to PlatformDispatcher and multi-window (flutter/engine#21932)

* 5ca5e26 Add FlEventChannel (flutter/engine#21316)

* 77b0052 Roll Skia from 65674e4c2e56 to 01b05e5b830b (3 revisions) (flutter/engine#22062)

* 3d27fd5 Support loading assets from Android dynamic feature modules (flutter/engine#21504)

* 742dfbe support uri intent launcher in android (flutter/engine#21275)

* cde1e3f Auto detect mode to determine which rendering backend to use. (flutter/engine#21852)

* 329ccf7 Roll Skia from 01b05e5b830b to 53281c712159 (1 revision) (flutter/engine#22065)

* cde78c1 Add a golden scenario test for fallback font rendering on iOS take 2 (flutter/engine#22033)

* 4f4599b Roll Dart SDK from 9f907e198970 to 37ccceacad41 (3 revisions) (flutter/engine#22069)

* f0b10c5 [web] Prevent using DOM nodes for canvas with large number of draws (flutter/engine#22064)

* a86ba57 Roll Fuchsia Mac SDK from WLxBkBnZa... to zDfaxkqlv... (flutter/engine#22073)

* 645198a Roll Fuchsia Linux SDK from gqS_DIjN4... to vuKxZmSVj... (flutter/engine#22074)

* 0b26570 Revert dart rolls (flutter/engine#22078)
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
@chunhtai @chaselatta
Fixes Edge trigger route change announcement (flutter#21975)
cab3ae9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer Awaiting requested review from goderbauer

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes platform-android platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS accessibility bridge does not detect scope route change correctly
3 participants
@chunhtai @jonahwilliams @fluttergithubbot