Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e7d7edab98ad
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c76035429c36
Choose a head ref
  • 14 commits
  • 15 files changed
  • 9 contributors

Commits on Nov 7, 2022

  1. clang-tidy: added the ability to shard jobs (#37265)

    * clang-tidy: added the ability to shard jobs
    
    * added test
    
    * jenn feedback
    
    * hack ci to run as a shard to measure the time
    
    * tweak
    
    * fix hack
    
    * zach feedback
    
    * zach feedback 2
    
    * removed stray async
    
    * moved to using sets for lookups
    
    * fixed typo in docstring
    
    * Revert "fix hack"
    
    This reverts commit 06a61a6.
    
    Revert "tweak"
    
    This reverts commit e7c58b1.
    
    Revert "hack ci to run as a shard to measure the time"
    
    This reverts commit e458963.
    
    * removed calls to map
    
    * turned the ci hack back on
    
    * Revert "turned the ci hack back on"
    
    This reverts commit 0d53794.
    
    * removed sync*
    gaaclarke authored Nov 7, 2022
    Configuration menu
    Copy the full SHA
    de0b58e View commit details
    Browse the repository at this point in the history
  2. Roll Dart SDK from d97d5ad to b22b36c (1 revision) (#37400)

    https://dart.googlesource.com/sdk.git/+log/d97d5ad98893..b22b36c0f52e
    
    2022-11-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-375.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC dart-vm-team@google.com,garyq@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8aefb8b View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Roll Skia from aef6d301c0b5 to 0c8127b3dd7d (6 revisions) (#37402)

    https://skia.googlesource.com/skia.git/+log/aef6d301c0b5..0c8127b3dd7d
    
    2022-11-07 johnstiles@google.com [cleanup] Minor cleanup in Raster Pipeline.
    2022-11-07 michaelludwig@google.com [skif] Be more lenient about merging passes with NN filtering
    2022-11-07 bungeman@google.com Revert "Disable "use_header_modules" with SkOpts in Bazel"
    2022-11-07 kjlubick@google.com [bazel] Add rules to compile SkSL tests
    2022-11-07 kjlubick@google.com [sksl] Modify sksl_compile_tests to be more Bazel friendly
    2022-11-07 kjlubick@google.com Skip timeout-prone skp for wasm CPU
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC garyq@google.com,lovisolo@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    2f04309 View commit details
    Browse the repository at this point in the history
  2. Fix boolean json property. (#37403)

    The json translation of gclient_vars is failing because it can't parse
    the boolean value as True.
    
    Bug: flutter/flutter#114656
    godofredoc authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    dc7cb20 View commit details
    Browse the repository at this point in the history
  3. Adding release_build:true property to windows builders. (#37397)

    This will run the specified jobs under the release builder
    recipe in dart-internal.
    
    Bug:b/232552448
    yusuf-goog authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    512fa40 View commit details
    Browse the repository at this point in the history
  4. Add test for image readback (#37401)

    Harry Terkelsen authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    0af8707 View commit details
    Browse the repository at this point in the history
  5. Update display_list_image_filter_unittests to be permit Skia roll (#3…

    …7327)
    
    * Update display_list_image_filter_unittests to be permit Skia roll
    
    https://skia-review.googlesource.com/c/skia/+/571798 had to be reverted because it causes DisplayListImageFilter.LocalImageFilterBounds to fail. With SkMatrixTransformImageFilter (returned by SkImageFilters::MatrixTransform) supporting complex matrices, makeWithLocalMatrix(rotation) will no longer return null.
    
    This is at odds with the behavior of DlImageFilter's implementation which tries to mimic the existing behavior of image filters. This relaxes the test case so that Skia can improve its implementation without breaking Flutter's tests. Flutter can then update DlImageFilter to match out-of-band.
    
    * Update comment to reference flutter issue.
    lhkbob authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    c6f26e0 View commit details
    Browse the repository at this point in the history
  6. Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (#37409)

    https://skia.googlesource.com/skia.git/+log/0c8127b3dd7d..8b19fb0f57d4
    
    2022-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 4cd8452c3caf to eb949c87ee5a (14 revisions)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC garyq@google.com,lovisolo@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    4e9e97b View commit details
    Browse the repository at this point in the history
  7. Pass the correct name for gclient variables in ci.yaml (#37429)

    The right name in .ci.yaml is gclient_variables instead of
    gclient_custom vars.
    godofredoc authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    42c2940 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2e2a2fd View commit details
    Browse the repository at this point in the history
  9. Roll Fuchsia Mac SDK from sa5bVGimNo3JwLV27... to d4l6A1aPw6Z0YjxmA... (

    #37432)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
    Please CC jimgraham@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    02cb789 View commit details
    Browse the repository at this point in the history
  10. [web] Use v8BreakIterator where possible (#37317)

    * [web] Use v8BreakIterator where possible
    
    * address review comments
    mdebbar authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    c24ae18 View commit details
    Browse the repository at this point in the history
  11. Add rects to accumulator rather than bounds (#37435)

    When the accumulator is an `RTreeBoundsAccumulator` rather than a `RectBoundsAccumulator` just accumulating the bounds results in incorrect results as the `rtree` would need to be aware of the constituent non-overlapping rectangles. This would work fine for `RectBoundsAccumulator` as it would just adjust its bounds based on the passed rects.
    
    Fixes: flutter/flutter#113251
    iskakaushik authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    306b0fe View commit details
    Browse the repository at this point in the history
  12. Roll Dart SDK from b22b36c to c15cdb9 (2 revisions) (#37437)

    https://dart.googlesource.com/sdk.git/+log/b22b36c0f52e..c15cdb978761
    
    2022-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-377.0.dev
    2022-11-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-376.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    c760354 View commit details
    Browse the repository at this point in the history
Loading