Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3dc8b71f96cc
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8a038a6f7099
Choose a head ref
  • 1 commit
  • 6 files changed
  • 1 contributor

Commits on Sep 10, 2024

  1. [skwasm] use temporary RawPaint objects (attempt #2) (#55035) 

    Relands #54917. The change is the same as before, except now the native resources for `SkwasmColorFilter` and `SkwasmImageFilter` classes are no longer GC'd. Instead, we use manually managed native handles (vended and scoped by `withRawColorFilter` and `withRawImageFilter`). The bug in the previous PR was that filter objects were disposed with the paint while the framework continued holding onto them. When GC kicked the finalization registry, it attempted to double-free the filters.
    @yjbanov
    yjbanov authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8a038a6 View commit details
    Browse the repository at this point in the history
Loading