Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

refactor: remaining code migrated to null safety #624

Merged
merged 3 commits into from
Mar 30, 2022
Merged

refactor: remaining code migrated to null safety #624

merged 3 commits into from
Mar 30, 2022

Conversation

amanv8060
Copy link
Contributor

@amanv8060 amanv8060 commented Mar 29, 2022 •
edited
Loading

refactor: remaining code migrated to null safety leaving tests to be migrated

part of #527

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@amanv8060 amanv8060 force-pushed the remaining_migrations branch from a0f5b6b to 67d94ab Compare March 29, 2022 21:30
guidezpl
guidezpl reviewed Mar 30, 2022
View reviewed changes
@guidezpl
Copy link
Member

LGTM! Is there anything else to do?

@amanv8060 amanv8060 marked this pull request as ready for review March 30, 2022 09:01
@amanv8060
Copy link
Contributor Author

no, will migrate the tests this week as well.

@amanv8060 amanv8060 mentioned this pull request Mar 30, 2022
Closed
@guidezpl
Copy link
Member

thanks you so much!

@guidezpl guidezpl merged commit 93d406a into flutter:master Mar 30, 2022
@amanv8060 amanv8060 deleted the remaining_migrations branch March 30, 2022 12:56
@amanv8060
Copy link
Contributor Author

amanv8060 commented Mar 30, 2022 •
edited
Loading

this has caused an issue, looks like tests are passing, but the app doesn't run for me. can this be reverted?
or I am creating a pr to fix

@amanv8060 amanv8060 restored the remaining_migrations branch March 30, 2022 16:09
@amanv8060 amanv8060 mentioned this pull request Mar 30, 2022
Merged
8 tasks
@guidezpl
Copy link
Member

all works fine with #625, I went through the whole app and only found one other bug: if you open settings in the upper right, selecting a different text scaling option. Do you mind taking a look?

@amanv8060 amanv8060 deleted the remaining_migrations branch March 30, 2022 18:16
@amanv8060 amanv8060 mentioned this pull request Mar 30, 2022
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@guidezpl guidezpl guidezpl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanv8060 @guidezpl