Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

revert goldens #675

Merged
merged 1 commit into from
May 4, 2022
Merged

revert goldens #675

merged 1 commit into from
May 4, 2022

Conversation

pq
Copy link
Contributor

@pq pq commented May 3, 2022 •
edited
Loading

Follow-up from: #672 (comment).

Apologies for the noise!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pq pq mentioned this pull request May 3, 2022
Closed
8 tasks
@pq pq requested a review from guidezpl May 3, 2022 21:56
@guidezpl
Copy link
Member

guidezpl commented May 4, 2022

No worries, thanks!

@guidezpl guidezpl merged commit b72a708 into flutter:master May 4, 2022
@pq pq deleted the revert_goldens_+++ branch May 4, 2022 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@guidezpl guidezpl guidezpl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pq @guidezpl