This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Apply upcoming flutter lints #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami-a
approved these changes
May 25, 2021
| @@ -22,7 +23,7 @@ final valueList = <String>[ | |||
| /// Tests that the Gallery web benchmarks are run and reported correctly. | |||
| Future<void> main() async { | |||
| test('Can run a web benchmark', () async { | |||
| print('Starting web benchmark tests ...'); | |||
| stdout.writeln('Starting web benchmark tests ...'); | |||
There was a problem hiding this comment.
These changes seem odd, any idea why they happened?
There was a problem hiding this comment.
Yeah, this it the lint https://dart-lang.github.io/linter/lints/avoid_print.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply most upcoming lints from https://flutter.dev/docs/release/breaking-changes/flutter-lints-package, but still rely on
pedantic(can only include 1 inanalysis_options.yaml)consts overfinal,constconstructors withKey, replacing unnecessaryContainers withSizedBox, string interpolation, debug printing, subclass parameter naming