This repository was archived by the owner on Jun 13, 2024. It is now read-only.
[State Restoration] DataTable selected rows state #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
reviewed
Jan 6, 2021
| @@ -17,11 +17,39 @@ class DataTableDemo extends StatefulWidget { | |||
| _DataTableDemoState createState() => _DataTableDemoState(); | |||
| } | |||
|
|
|||
| class _RestorableSelectedDessertIndices extends RestorableValue<Set<int>> { | |||
There was a problem hiding this comment.
This design makes it tempting to just modify the values set directly, which doesn't work because those updates will not be restored.
Instead of exposing the value set directly, I would write a custom RestorableProperty, which does not expose the set and instead has an interface like this:
class Foo extends ... {
setSelection(Set<int> selectedIndexes);
isSelected(int index);
}
|
Ready for another round of review. I also fixed an issue where the selected count of the data table wasn't being restored correctly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out state restoration has to be done on the user side of things. In
PaginatedDataTables,DataRows are created by theDataTableSourceclass. This PR adds state restoration to the selection state of thePaginatedDataTable.Closes flutter/flutter#70916