This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Rename CardDemoType
and type
#311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
CardDemoType
→CardType
type
→cardType
allowing DartPad code generator to better understand them.
Explanation
The DartPad code generator looks for all variables named
type
and replaces them with a specific demo type; for example, inmaterial/dialog_demo.dart
, the variabletype
always refer to the type of the demo we are running (one ofalert
,alertTitle
,simple
,fullscreen
), so the code generator will replacetype
withDialogDemoType.alert
,DialogDemoType.alertTitle
,DialogDemoType.simple
, andDialogDemoType.fullscreen
in order to generate standalone apps for each demo type.Since the
type
inmaterial/cards_demo.dart
refers to the type of the card we use, instead of the type of the demo, renaming it tocardType
allows the code generator to avoid replacing them.