This repository was archived by the owner on Jun 13, 2024. It is now read-only.
[Reply] Fix flicker on empty mailbox and prefer ListView.builder #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perclasson
pushed a commit
to perclasson/gallery
that referenced
this pull request
Sep 16, 2020
* Update pubspec and pubspec.lock Upgrade packages to latest allowable version Specify ^ for packages missing it * Disallow GoogleFonts http loading Former-commit-id: acbeb82
rami-a
approved these changes
Sep 16, 2020
clocksmith
approved these changes
Sep 17, 2020
…ation-flicker-fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings in inbox updates from the Reply codelab material-components/material-components-flutter-motion-codelab#12 . We prefer to use ListView.builder over ListView for lazy building. And disable primary, to disable scrolling when content is not sufficient to scroll.
This change also fixes an issue where the inbox was rebuilding twice when going going to a destination with no emails.