This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Migrate gallery to new button universe #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clocksmith
reviewed
Oct 13, 2020
clocksmith
approved these changes
Oct 13, 2020
perclasson
approved these changes
Oct 13, 2020
|
Added, they look right to me I think
|
|
The height of the Rally button looks slightly wrong (it's outside of the scope of this PR probably). It should look something like this: |
I think it is out of scope, checking rally on master and it looks the same to me: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves all gallery demos and studies to use new button universe
Closes #207
Closes #208