This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Revert "[a11y-web] adding enabled to button semantics " #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing the PR: #219 (comment) |
|
I actually take back my statement that this should be reverted, see #219 (comment). Since it only adds Nevertheless, the web engine still has the bug that it should only mark something as disabled when Sorry about the confusion. |
clocksmith
pushed a commit
to clocksmith/gallery
that referenced
this pull request
Jul 23, 2020
Former-commit-id: e37fb8a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #219
We concluded that the issue is to be fixed in the web engine. Reverting this change.