This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Update to new android embedding v2 #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami-a
approved these changes
Jul 16, 2020
|
|
||
| This Theme is only used starting with V2 of Flutter's Android embedding. --> | ||
| <style name="NormalTheme" parent="@android:style/Theme.Black.NoTitleBar"> | ||
| <item name="android:windowBackground">@android:color/white</item> |
There was a problem hiding this comment.
Is this white the color of the splash screen when the android app launches? If so, can we make it black instead?
There was a problem hiding this comment.
Sorry just saw this, the normal theme is the background that shows up briefly when changing the device orientation, briefly after the LaunchTheme, or during activity restoration. So far I haven't been able to capture it. The splash screen is set to black in the LaunchTheme, should we also set this one to black?
There was a problem hiding this comment.
yeah I think that makes sense
clocksmith
pushed a commit
to clocksmith/gallery
that referenced
this pull request
Jul 23, 2020
Former-commit-id: 3abdc6a
guidezpl
approved these changes
Aug 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warning when doing flutter run
Your Flutter application is created using an older version of the Android embedding. It's being deprecated in favor of Android embedding v2. Follow the steps on https://flutter.dev/go/android-project-migration to migrate your project.Instructions to update outlined here: https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects