This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Modify the deviceLocale workaround for all desktop platforms #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami-a
approved these changes
Jun 19, 2020
| @@ -1,7 +1,3 @@ | |||
| // Copyright 2014 The Flutter Authors. All rights reserved. | |||
There was a problem hiding this comment.
Why remove the copyright header?
There was a problem hiding this comment.
This file was autogenerated, so leaving as is
guidezpl
added a commit
that referenced
this pull request
Jun 27, 2020
* Update gallery_options.dart * Update gallery_options.dart * Update Podfile & android settings.gradle Former-commit-id: 576217a
DanTup
pushed a commit
to DanTup/flutter_gallery
that referenced
this pull request
Jun 30, 2020
Add details for the Shrine study in the Gallery app: Use correct letter spacing from the spec. Former-commit-id: d5189f8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround currently only accounts for macOS when it should account for all desktop platforms.
Also update ios/Podfile, android/settings.gradle and other files for smooth running on all platforms (autogenerated)
Closes #172