Feat-transient-base-ingestor #27

Myestery · 2024-07-15T18:18:18Z

Mint Ingestor: Transient

Functionality Supported

Ingesting from URL: Yes
Ingesting from Contract address: Yes
Supported Networks: Base

Before you submit

Ensure your generated MintTemplate works 😄
Ensure that your code is restricted to a single folder in src/ingestors
Ensure that all required assets are included (e.g. ABIs)
Ensure ABIs are trimmed to include only methods (1) used in the ingestor or (2) required to mint
Ensure that all exported methods are prefixed with the name of your ingestor e.g. myMintingPlatformGetContractDetails
Ensure that a test exists for generating a MintTemplate that will always succeed
Ensure that your code accesses no external resources except those passed in the resources object

fix #8

Myestery · 2024-07-15T18:21:30Z

Hello @christinehall
I was able to add an ingestor for the transient network.

I noticed the mint contract was different from the nft contract too

chrismaddern · 2024-07-16T01:44:27Z

Thank you for this submission!! 🥳 🙏

We've gotten a little behind on reviewing these, but will be spending some time over the next 48 hours, so look out for some feedback soon! Thank you! 🙏

src/ingestors/transient-base/index.ts

chrismaddern · 2024-07-16T20:04:13Z

src/ingestors/transient-base/index.ts

+      contractAddress,
+      mintAddress,
+      contractMethod: 'purchase',
+      contractParams: '["address", 1, 1, address]',


Looking at the ABI above, is this right?

https://github.com/floornfts/mobile-minting/pull/27/files#diff-7b9dec2faf20a75b53006dc8f4835e4f6d5e131c7287e038cb46cccd657bb7daR11

Are the last properties optional? And are nftAddress and recipient supposed to both be the recipient's address?

// nftAddress address 0x8F7F96eEc76c882C327a1b927D04C87031ED5481 // 1 tokenId uint256 1 // 2 recipient address 0xcA4700293Bd3b48E7051116635C82546F17a61e3 // 3 numberToMint uint256 1 // 4 presaleNumberCanMint uint256 0 // 5 proof bytes32[]

The above is a sample contract interaction pulled from the explorer for a successful purchase on transient

The nftAddress should be the address of the nft
and yes recipient address should be address of recipient. ABI says this allows for buying for others

I'm a bit unsure of what contractParams: '["address", 1, 1, address]', should be atm

I set it to
["${contract.contractAddress}", 1, address, 1],

I believe it represents the structure better now

Myestery · 2024-07-17T19:06:55Z

@chrismaddern I have made the necessary corrections, should be good now

chrismaddern · 2024-07-19T12:31:55Z

Hi @Myestery

Are you able to run the tests locally?

If you:

Add an ALCHEMY_API_KEY var in your local .env
Run yarn test

I've also just added support for simulating transactions to the tests basicIngestorTests

Can you merge the floornfts/mobile-minting branch into yours? There are several failing manual tests already, but this also indicates that the constructed payload does not execute successfully onchain:

Let me know if you have any questions, otherwise, making the tests pass is the right next step 😊

Myestery · 2024-07-19T12:33:55Z

Thanks for fixing the tests,
I'll run them now

Myestery · 2024-07-19T12:50:31Z

I actually have some trouble running the test
I still get ts errors after merging main branch

chrismaddern · 2024-07-19T14:44:40Z

All local machines and CI seem to be building it okay which is odd - I'm not 100% sure what the problem is:

Setup

MacOS Sonoma
Node 20.9.0 (we could probably use a node version lock file in the repo actually)
The rest of the deps should be pinned in yarn.lock (I assume you used yarn install?)

Do you have any global TS config that could be applying?

Ah, if you're having a hard time running yarn install, you may want to try removing the .npmrc file locally -- that's designed for building and distribution, but can interact with yarn install too.

git update-index --assume-unchanged .npmrc
rm .npmrc

This will remove it locally, while preventing that change from being pushed to git

Myestery · 2024-07-19T16:26:22Z

All local machines and CI seem to be building it okay which is odd - I'm not 100% sure what the problem is:

Setup

MacOS Sonoma

Node 20.9.0 (we could probably use a node version lock file in the repo actually)

The rest of the deps should be pinned in yarn.lock (I assume you used yarn install?)

Do you have any global TS config that could be applying?

Ah, if you're having a hard time running yarn install, you may want to try removing the .npmrc file locally -- that's designed for building and distribution, but can interact with yarn install too.
git update-index --assume-unchanged .npmrc
rm .npmrc
This will remove it locally, while preventing that change from being pushed to git

I finally got it to work using node 20

Myestery · 2024-07-19T16:28:12Z

@chrismaddern The tests are passing now
I noticed switching the simulate env made my tests pass but some of fxhash to fail

chrismaddern · 2024-07-20T19:20:55Z

src/ingestors/transient-base/index.ts

+      chainId,
+      contractAddress: mintAddress,
+      contractMethod: 'purchase',
+      contractParams: `[address, ${token_id}, address, 1, 0, []]`,


If you merge the latest from mobile-minting main, it will now run a simulation for you in running the tests.

This reveals that these params are incorrect.

Consulting the ABI:

{ internalType: 'address', name: 'nftAddress', type: 'address' }, { internalType: 'uint256', name: 'tokenId', type: 'uint256' }, { internalType: 'address', name: 'recipient', type: 'address' }, { internalType: 'uint256', name: 'numberToMint', type: 'uint256' }, { internalType: 'uint256', name: 'presaleNumberCanMint', type: 'uint256' }, { internalType: 'bytes32[]', name: 'proof', type: 'bytes32[]' },

The important one is...

Param 1: This is the Address of the NFT collection, not the user

Replacing this with:

contractParams: `["${contractAddress}", "${token_id}", address, 1, 0, []]`,

fixes one part of the problem

The next is that the price wei for the test is being set to 20000000000000000, but minting on metamask reveals it's actualy 0.00209.

The priceWei is missing the mint fee it seems.

Hopefully this helps get it across the line!

Thanks @chrismaddern !
I figured the fee some hours ago

However, I noticed there are about 4 contract types on Base Network that Transient supports today

ERC721TL

ERC1155TL

ER7160TL (The contract for Kansas smile)

Trace

I'll be adding support for them before the next review

All tests are passing now tho
Pls let me know if I should proceed with adding support for the remaining 3 contract types

Amazing, yes — support for all Base supported types would be extremely helpful. Particularly the 721TL is important (and I think most of their mints?)

…-ingestor

chrismaddern · 2024-07-20T21:54:33Z

Amazing! Seeing the same thing on my end!!!

Nice work... I'll wait for the final types (they're just different minter addresses, hopefully?) and then we can get this in and unlock the bounty!! 🥳 🚀

Myestery · 2024-07-21T20:04:58Z

All done @chrismaddern

I added more tests to ensure the other contract types are working and fixed some minor flaws with the ingestor.
I think its completed !

chrismaddern · 2024-07-22T13:15:04Z

Amazing!

Could you add example URLs for each to the successUrls for the basicIngestorTests?

Currently only the one URL is being simulated in tests:

Also, you can run simulations during testing locally by adding the following to your .env:

SIMULATE_DURING_TESTS=true

When I do this locally:

basicIngestorTests(new TransientIngestor(), resources, {
    successUrls: [
      'https://www.transient.xyz/stacks/kansas-smile',
      'https://www.transient.xyz/stacks/volumina-8',
      'https://www.transient.xyz/stacks/16384',
    ],

If you need to fix the blockHash at which the tests run the simulation you can do so here:
https://github.com/floornfts/mobile-minting/blob/main/test/ingestors/prohibition-daily.test.ts#L27

Note that all test cases currently need to be able to simulate successfully at the same blockhash (i.e. have been live & available at the same time)

Myestery · 2024-07-22T14:13:21Z

Amazing!

Could you add example URLs for each to the successUrls for the basicIngestorTests?

Currently only the one URL is being simulated in tests:

Also, you can run simulations during testing locally by adding the following to your .env:
SIMULATE_DURING_TESTS=true
When I do this locally:
basicIngestorTests(new TransientIngestor(), resources, {
    successUrls: [
      'https://www.transient.xyz/stacks/kansas-smile',
      'https://www.transient.xyz/stacks/volumina-8',
      'https://www.transient.xyz/stacks/16384',
    ],
If you need to fix the blockHash at which the tests run the simulation you can do so here: https://github.com/floornfts/mobile-minting/blob/main/test/ingestors/prohibition-daily.test.ts#L27

Note that all test cases currently need to be able to simulate successfully at the same blockhash (i.e. have been live & available at the same time)

I fixed the tests, I noticed a slight change with the ABI for ERC721TL and ERC7160TL contracts

Myestery · 2024-07-22T14:17:46Z

All done 💯

chrismaddern · 2024-07-22T18:57:48Z

Huzzah! Will review for merge.

Meanwhile, I'll DM you on the Twitter profile on your Github page with follow up for the bounty 🙂

chrismaddern · 2024-07-23T17:29:21Z

@Myestery did you get the DM? 👀

Myestery · 2024-07-23T17:31:18Z

@Myestery did you get the DM? 👀

yes, seen now

Myestery · 2024-07-23T17:33:58Z

@Myestery did you get the DM? 👀

yes, seen now

Filled.
Thanks

Myestery · 2024-07-24T23:22:59Z

Hey @chrismaddern
I noticed the test failed recently and I did some investigation
I found out that they could close the nft sale before the public sale date ended
that was the issue for kansas-smile

Myestery · 2024-07-24T23:24:21Z

Hey @chrismaddern I noticed the test failed recently and I did some investigation I found out that they could close the nft sale before the public sale date ended that was the issue for kansas-smile

It got closed some minutes ago
https://api.transient.xyz/v1/catalog/stacks/kansas-smile

chrismaddern · 2024-07-24T23:56:52Z

@Myestery will observed!

I added a blockhash to the basicIngestor tests in this PR here → #31

chrismaddern · 2024-07-24T23:57:18Z

You should be able to merge main now! 😊

Myestery added 3 commits July 15, 2024 18:46

chore: add offchain metadata methods

da71648

chore: added tests for transient ingestor

6dd6b4b

trim abi

30d746b

chrismaddern reviewed Jul 16, 2024

View reviewed changes

src/ingestors/transient-base/index.ts Show resolved Hide resolved

chrismaddern reviewed Jul 16, 2024

View reviewed changes

src/ingestors/transient-base/index.ts Outdated Show resolved Hide resolved

chrismaddern reviewed Jul 16, 2024

View reviewed changes

Myestery added 3 commits July 16, 2024 21:24

chore: set creator data and output contract

cd07ad6

chose: set contract address parameter correctly

2111316

chore: add token id to contract parameters

d94919f

Myestery requested a review from chrismaddern July 17, 2024 11:54

chrismaddern and others added 6 commits July 19, 2024 13:48

Default to 0

f77411b

Fix test

916cd7a

v1.0.8

de7dd79

Add simulations to tests & dry runs

fbb0e0c

SIMULATE_DURING_TESTS=true

c82fd00

remove prohibition constructor

13ca8ee

fix issues with contract params

d870b7c

chrismaddern reviewed Jul 20, 2024

View reviewed changes

Myestery added 2 commits July 20, 2024 22:00

add protocol fee support from onchain metadata

ebda82e

Merge remote-tracking branch 'upstream/main' into feat-transient-base…

9bf1977

…-ingestor

Myestery added 2 commits July 21, 2024 21:00

chore: added tests for ERC721TL and ERC7160TL contracts

2d5bf39

chore: Refactor TransientIngestor to use updated Transient API

d2dced6

feat: edit abi for ERC721TL and ERC7160TL contracts

9437dc5

chrismaddern added accepted final-approach labels Jul 24, 2024

chrismaddern merged commit dd1e040 into floornfts:main Jul 24, 2024

Feat-transient-base-ingestor #27

Feat-transient-base-ingestor #27

Uh oh!

Conversation

Myestery commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mint Ingestor: Transient

Functionality Supported

Before you submit

Uh oh!

Myestery commented Jul 15, 2024

Uh oh!

chrismaddern commented Jul 16, 2024

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Myestery commented Jul 17, 2024

Uh oh!

chrismaddern commented Jul 19, 2024

Uh oh!

Myestery commented Jul 19, 2024

Uh oh!

Myestery commented Jul 19, 2024

Uh oh!

chrismaddern commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Myestery commented Jul 19, 2024

Uh oh!

Myestery commented Jul 19, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrismaddern commented Jul 20, 2024

Uh oh!

Myestery commented Jul 21, 2024

Uh oh!

chrismaddern commented Jul 22, 2024

Uh oh!

Myestery commented Jul 22, 2024

Uh oh!

Myestery commented Jul 22, 2024

Uh oh!

chrismaddern commented Jul 22, 2024

Uh oh!

chrismaddern commented Jul 23, 2024

Uh oh!

Myestery commented Jul 23, 2024

Uh oh!

Myestery commented Jul 23, 2024

Uh oh!

Myestery commented Jul 24, 2024

Uh oh!

Myestery commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrismaddern commented Jul 24, 2024

Uh oh!

chrismaddern commented Jul 24, 2024

Uh oh!

Uh oh!

Myestery commented Jul 15, 2024 •

edited

Loading

chrismaddern commented Jul 19, 2024 •

edited

Loading

Myestery commented Jul 24, 2024 •

edited

Loading