Skip to content

chore: bump etag length for multi-docs to 32 #4501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

chore: bump etag length for multi-docs to 32 #4501

merged 1 commit into from
Aug 1, 2025

Conversation

markphelps
Copy link
Collaborator

Re: #4500

@markphelps
chore: bump etag length for multi-docs to 32
e9e492f 
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@markphelps markphelps requested a review from erka August 1, 2025 13:41
@markphelps markphelps requested a review from a team as a code owner August 1, 2025 13:41
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 1, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.75%. Comparing base (2acc26a) to head (e9e492f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4501   +/-   ##
=======================================
  Coverage   63.75%   63.75%           
=======================================
  Files         171      171           
  Lines       17631    17631           
=======================================
  Hits        11240    11240           
  Misses       5720     5720           
  Partials      671      671
Flag Coverage Δ
unittests 63.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@markphelps markphelps mentioned this pull request Aug 1, 2025
Merged
@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Aug 1, 2025
erka
erka approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably could go with 40 characters too

@kodiakhq kodiakhq bot merged commit 230d268 into main Aug 1, 2025
40 checks passed
@kodiakhq kodiakhq bot deleted the bump-etag-length branch August 1, 2025 14:27
markphelps added a commit that referenced this pull request Aug 1, 2025
@markphelps
Merge branch 'main' into release/1.59
d891fe5 
* main:
  chore: bump etag length for multi-docs to 32 (#4501)
  fix(storage): add namespace ETag support across multiple files (#4500)
  fix(ui): variant with no name is not shown in the rules (#4499)
  Update github.com/bufbuild/buf in _tools to v1.55.1 (#4460)
  chore: ensure v1 release workflows only run on a v1 release (#4458)
  chore: remove the sandbox section from readme (#4447)
  chore: Release/1.59 (#4446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erka erka erka approved these changes

Assignees
No one assigned
Labels
automerge Used by Kodiak bot to automerge PRs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markphelps @erka