Skip to content

fix(ui): variant with no name is not shown in the rules #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

fix(ui): variant with no name is not shown in the rules #4499

merged 1 commit into from
Jul 29, 2025

Conversation

erka
Copy link
Contributor

@erka erka commented Jul 28, 2025 •
edited
Loading

closes #4498

@erka
fix(ui): variant with no name is not shown in the rules
0141f2a 
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka erka requested a review from a team as a code owner July 28, 2025 22:30
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 28, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.73%. Comparing base (65c6e37) to head (0141f2a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4499      +/-   ##
==========================================
+ Coverage   63.69%   63.73%   +0.03%     
==========================================
  Files         171      171              
  Lines       17622    17622              
==========================================
+ Hits        11225    11231       +6     
+ Misses       5724     5720       -4     
+ Partials      673      671       -2
Flag Coverage Δ
unittests 63.73% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

markphelps
markphelps approved these changes Jul 29, 2025
View reviewed changes
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@markphelps markphelps merged commit 1c50aac into main Jul 29, 2025
53 of 63 checks passed
@markphelps markphelps deleted the rd/v1/quick-rule-selector branch July 29, 2025 12:07
markphelps added a commit that referenced this pull request Aug 1, 2025
@markphelps
Merge branch 'main' into release/1.59
d891fe5 
* main:
  chore: bump etag length for multi-docs to 32 (#4501)
  fix(storage): add namespace ETag support across multiple files (#4500)
  fix(ui): variant with no name is not shown in the rules (#4499)
  Update github.com/bufbuild/buf in _tools to v1.55.1 (#4460)
  chore: ensure v1 release workflows only run on a v1 release (#4458)
  chore: remove the sandbox section from readme (#4447)
  chore: Release/1.59 (#4446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erka @markphelps