-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add org.multimc.MultiMC (MultiMC) #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bot, build org.multimc.MultiMC |
Queued test build for org.multimc.MultiMC. |
Started test build 33936 |
Build 33936 failed |
bot, build org.multimc.MultiMC |
Queued test build for org.multimc.MultiMC. |
Started test build 33937 |
Build 33937 failed |
bot, build org.multimc.MultiMC |
Queued test build for org.multimc.MultiMC. |
Started test build 33938 |
Build 33938 successful
|
org.multimc.MultiMC.yml
Outdated
- type: patch | ||
path: java-utils.patch | ||
- type: file | ||
path: org.multimc.MultiMC.appdata.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New appdata files should use metainfo instead. https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html
bot, build org.multimc.MultiMC |
Queued test build for org.multimc.MultiMC. |
Started test build 34061 |
Build 34061 successful
|
bot, build org.multimc.MultiMC |
Queued test build for org.multimc.MultiMC. |
This latest build adds some build switches that were found in the stable release PKGBUILD: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=multimc5#n55 |
Build 34376 successful
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this distribution is not verified by, affiliated with, or supported by the MultiMC team.
Where are your bug tracker and other support channels for problems with the bundled app?
Every application maintained on flathub has its own bug tracker. For example, here is the Obsidian flatpak bug tracker:
https://github.com/flathub/md.obsidian.Obsidian/issues
And here is upstream Obsidian's bug tracker for general Linux bugs:
https://forum.obsidian.md/search?q=linux%20category%3A7%20order%3Alatest
Hey @peterix, my apologies for the late response!
I'm sorry you've had to deal with cracked clients. I've supported Minecraft since it was in Alpha development, and it can be frustrating to see the MC community being flooded with shady mods and cracked launchers undermining the efforts and legitimacy of those who've put their time into Minecraft and passion projects such as MultiMC.
Auditability is a very important property in software, and I'm glad that you prioritize it. There are a few ways you can audit flatpak builds: It would be virtually impossible for someone to sneak in shady patches because it would need approval for merging from a maintainer, and there's an extensive audit trail left behind since it's all publicly visible in git history. For example, this is the commit hash of the latest change I made as of this writing: Which is found in the Build Properties of the respective build in Flathub's CI: https://flathub.org/builds/#/builders/32/builds/34376 The build output can be readily inspected and compared against local builds, which I often do by running:
As barthalion pointed out, the expected procedure for supporting a flatpak is that users file bugs on its bug tracker. It's not any different from users having to go to a bug tracker for Debian, Fedora, etc. For example, there's a bug tracker for the Obsidian flatpak I maintain In addition to there being a bug tracker, flatpak gives users the tooling they need to extensively debug. This has been useful for when I've had to help debug Wayland crashes with the Veloren developers:
Out-of-the-box Java support can certainly be moved out of the build for fitting more in line with the goals of Minecraft and MultiMC. The current configuration of bundling the prepackaged openjdk8 is not intrinsic to flatpak; you can either keep the base application minimal with support libraries installed separately, or bundle whatever you feel is necessary. In this case, it's merely a convenience for first runs because flathub already packages openjdk8, and whether it's bundled or installed as a shared system library is irrelevant due to ostree's design deduplicating files.
Having to extensively patch MultiMC for a rebrand is certainly not going to be simple, but is necessary for satisfying requirements for a downstream package. If you can, please list which exact parts of the application would need to be patched. Here's a (probably incomplete) list of what I believe would have to be changed based on a cursory glance:
Whatever issues may impact the flatpak shouldn't be your problem, as it was already made clear from the very first commit as well as in the original license One of the key benefits of the open source community is that volunteers can put in improving the quality of software in a transparent, especially if there's a policy in upstreaming patches so that everyone can benefit. That is the relationship I intend to have when maintaining this.
The infrastructure already exists, otherwise the Flathub community wouldn't able to maintain the 1000+ apps at the time of this writing. MultiMC isn't going to be much different. |
Note: I am not a fltahub/flatpak decider, neither a Minecroft user. So the following should resolve the question to determine your true colors: |
I do not approve this. I said NO many times. And I see this continuing as hostile action. I will respond in kind if you force me. |
@peterix You said no to a "modified" version, a version that is exactly re-packaged from a binary package from your website without modification is something completely different, so you must be okay with that, unless you're completely hostile towards any other distribution than arch and ubuntu. |
No, I am against you repackaging or hosting MultiMC in any way. MultiMC comes from multimc.org - nowhere else. |
And that is final. |
If I have to make the repositories private and change the license, I will. |
You people are entirely inconsiderate, relentless and can't be reasoned with in any way. |
So far nothing has been published. You have actually said moments ago that you do not wish this to be redistributed |
Maybe you should consider 'no' as an answer and have some respect for other people. |
I can imagine that this has been as bad of a discussion for you as for anyone involved, which you could have avoided entirely. You probably didn't know but on flatpak irc people are very compassionate to not include MultiMC based on your wishes. If you wish to use the label open source, I would suggest that you also respect the open source initiative |
Great. That is the desired outcome. I do not want MultiMC to be in flatpak, appimage, snap or anything similar. You could have avoided this by not being aggressive and trying to take over everything. |
The desired outcome would definitely include also you not misrepresenting the open source brand. |
Go read the license again. It gives you no rights to the name. |
I suggest you do the same: |
|
which is covered by section 2 |
No, it is not. It's a distinct section of the license. |
@peterix Would you mind if we ask the OSI for clarification? |
Look, I'm telling you 'no, I don't want this' and you are trying to find some technicality to get around it and ignore what I say. |
I'm sorry but I don't want to get around anything, it's the other way around. You are basically saying open source (apache 2) is not redistributable based on some technicality which is covered by section 2. It seems to me that you've chosen the incorrect license for the project (an open source one). |
The license does not give you the right to use the name or the infrastructure MultiMC requires to function. There are two very distinct things: It is clear that I need to strip all branding from the open source code and make it present only in binary packages built by the MultiMC CI. |
I think this is a solution and glad that you can be reasoned with. |
People interested in having unbranded MultiMC on Flathub are welcome to submit it; at this point I don't want MultiMC on Flathub either. |
This initial pull request creates an unofficial distribution of MultiMC that includes the latest LTS release of OpenJDK to ensure it can launch successfully on first run.