Skip to content
This repository was archived by the owner on Jul 23, 2025. It is now read-only.

Add --exclude flag #97

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Add --exclude flag #97

merged 1 commit into from
Oct 8, 2021

Conversation

lmt-swallow
Copy link
Member

@lmt-swallow lmt-swallow commented Oct 8, 2021 •
edited
Loading

Description

This PR adds --exclude flag to shisho check and shisho find, which can be used to ignore files as follows:

shisho check [<opts>] --exclude "foo/*" --exclude "vendor/*" --exclude "node_modules/**"

This closes #94.

Checklist

  • I opened a draft PR or added the [WIP] to the title if my PR is not ready for review.
  • I have reviewed the code by myself.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests enough to show how your code behaves and that your code works as expected.

Additional Notes

N/A

@lmt-swallow
feat: add --exclude flag
cb4c2d0 
Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@lmt-swallow lmt-swallow self-assigned this Oct 8, 2021
@netlify
Copy link

netlify bot commented Oct 8, 2021 •
edited
Loading

✔️ Deploy Preview for cranky-fermi-e6c846 canceled.

🔨 Explore the source changes: cb4c2d0

🔍 Inspect the deploy log: https://app.netlify.com/sites/cranky-fermi-e6c846/deploys/615fe48737032e0008447205

@lmt-swallow lmt-swallow added the type: feature New feature label Oct 8, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #97 (cb4c2d0) into main (700eddf) will increase coverage by 0.19%.
The diff coverage is 63.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   75.27%   75.47%   +0.19%     
==========================================
  Files          30       30              
  Lines        1537     1586      +49     
==========================================
+ Hits         1157     1197      +40     
- Misses        380      389       +9
Impacted Files Coverage Δ
src/cli/subcommand/find.rs 0.00% <0.00%> (ø)
src/cli/subcommand/check.rs 56.71% <57.14%> (+2.98%) ⬆️
src/core/target.rs 67.96% <66.19%> (+11.06%) ⬆️
src/cli/tests/ruleset/mod.rs 90.00% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700eddf...cb4c2d0. Read the comment docs.

@lmt-swallow lmt-swallow merged commit 608ece1 into main Oct 8, 2021
@lmt-swallow lmt-swallow deleted the feature/exclude-flag branch October 8, 2021 06:27
@lmt-swallow lmt-swallow mentioned this pull request Oct 8, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@lmt-swallow lmt-swallow

Labels
type: feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow excluding files from search
2 participants
@lmt-swallow @codecov-commenter