This repository was archived by the owner on Jul 23, 2025. It is now read-only.
Fix handling of empty or undefined metavariables #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes handling of empty or undefined metavariables.
Suppose if we have (1) the following pattern:
and (2) the following code to match (in HCL, for example):
and (3) the following rewrite option:
The current version of Shisho emits the rewritten code with an unnecessary newline, due to metavariable C, as follows:
This PR changes this behaviour. In detail, now Shisho emits the following clean output:
Checklist
[WIP]
to the title if my PR is not ready for review.Additional Notes
N/A