Skip to content
This repository was archived by the owner on Jul 23, 2025. It is now read-only.

Ignore non YAMLs on ruleset loading #89

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Ignore non YAMLs on ruleset loading #89

merged 2 commits into from
Sep 29, 2021

Conversation

lmt-swallow
Copy link
Member

Description

This PR changes the behaviour of rule loader. Rule loader won't try to load non-YAMLs anymore.

Checklist

  • I opened a draft PR or added the [WIP] to the title if my PR is not ready for review.
  • I have reviewed the code by myself.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests enough to show how your code behaves and that your code works as expected.

Additional Notes

N/A

@lmt-swallow
bugfix: ignore non YAMLs on ruleset loading
8d60cf9 
Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@netlify
Copy link

netlify bot commented Sep 29, 2021 •
edited
Loading

✔️ Deploy Preview for cranky-fermi-e6c846 canceled.

🔨 Explore the source changes: 9554ae6

🔍 Inspect the deploy log: https://app.netlify.com/sites/cranky-fermi-e6c846/deploys/61540bdce37d6a00073b2676

@lmt-swallow
fix errors reported by clippy
9554ae6 
Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021 •
edited
Loading

Codecov Report

Merging #89 (9554ae6) into main (9fcdef2) will increase coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   75.66%   76.11%   +0.45%     
==========================================
  Files          26       27       +1     
  Lines        1463     1474      +11     
==========================================
+ Hits         1107     1122      +15     
+ Misses        356      352       -4
Impacted Files Coverage Δ
src/core/language.rs 73.07% <100.00%> (ø)
src/core/matcher/tree.rs 82.45% <100.00%> (ø)
src/core/ruleset.rs 62.06% <100.00%> (+10.21%) ⬆️
src/core/ruleset/test.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fcdef2...9554ae6. Read the comment docs.

@lmt-swallow lmt-swallow merged commit 287887b into main Sep 29, 2021
@lmt-swallow lmt-swallow deleted the bugfix/avoid-loading-non-yamls branch September 29, 2021 06:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmt-swallow @codecov-commenter