Skip to content
This repository was archived by the owner on Jul 23, 2025. It is now read-only.

feat: add title to rule definition #88

Merged
merged 1 commit into from
Sep 29, 2021
Merged

feat: add title to rule definition #88

merged 1 commit into from
Sep 29, 2021

Conversation

lmt-swallow
Copy link
Member

Description

This PR adds title field to Rule.

Checklist

  • I opened a draft PR or added the [WIP] to the title if my PR is not ready for review.
  • I have reviewed the code by myself.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests enough to show how your code behaves and that your code works as expected.

Additional Notes

N/A

Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@netlify
Copy link

netlify bot commented Sep 29, 2021

✔️ Deploy Preview for cranky-fermi-e6c846 canceled.

🔨 Explore the source changes: e9a2b50

🔍 Inspect the deploy log: https://app.netlify.com/sites/cranky-fermi-e6c846/deploys/6154094e100b92000854a9a6

@codecov-commenter
Copy link

Codecov Report

Merging #88 (e9a2b50) into main (9fcdef2) will decrease coverage by 0.18%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   75.66%   75.47%   -0.19%     
==========================================
  Files          26       26              
  Lines        1463     1468       +5     
==========================================
+ Hits         1107     1108       +1     
- Misses        356      360       +4     
Impacted Files Coverage Δ
src/core/ruleset.rs 51.85% <ø> (ø)
src/cli/reporter/console.rs 82.22% <55.55%> (-3.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fcdef2...e9a2b50. Read the comment docs.

@lmt-swallow lmt-swallow merged commit a90de07 into main Sep 29, 2021
@lmt-swallow lmt-swallow deleted the feature/title branch September 29, 2021 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants