Skip to content
This repository was archived by the owner on Jul 23, 2025. It is now read-only.

Conversation

lmt-swallow
Copy link
Member

Signed-off-by: Takashi Yoneuchi takashi.yoneuchi@shift-js.info

Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@lmt-swallow lmt-swallow self-assigned this Sep 29, 2021
@netlify
Copy link

netlify bot commented Sep 29, 2021

✔️ Deploy Preview for cranky-fermi-e6c846 canceled.

🔨 Explore the source changes: e1de462

🔍 Inspect the deploy log: https://app.netlify.com/sites/cranky-fermi-e6c846/deploys/6153ff34734a960007093dbb

@lmt-swallow lmt-swallow changed the title refactor: Prevent RootNode generation as possible refactor: Prevent RootNode generation as much as possible Sep 29, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #87 (e1de462) into main (0fb512d) will increase coverage by 1.03%.
The diff coverage is 94.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   74.62%   75.66%   +1.03%     
==========================================
  Files          26       26              
  Lines        1411     1463      +52     
==========================================
+ Hits         1053     1107      +54     
+ Misses        358      356       -2     
Impacted Files Coverage Δ
src/cli/reporter/json.rs 0.00% <0.00%> (ø)
src/core/matcher/tree.rs 82.45% <0.00%> (-0.88%) ⬇️
src/core/constraint.rs 47.05% <50.00%> (ø)
src/core/matcher/item.rs 64.10% <75.00%> (ø)
src/core/tree.rs 90.56% <80.00%> (ø)
src/cli/reporter/console.rs 85.88% <100.00%> (+0.16%) ⬆️
src/core/language/docker.rs 99.13% <100.00%> (+0.05%) ⬆️
src/core/language/go.rs 100.00% <100.00%> (ø)
src/core/language/hcl.rs 96.36% <100.00%> (+0.40%) ⬆️
src/core/node.rs 77.02% <100.00%> (+4.01%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb512d...e1de462. Read the comment docs.

@lmt-swallow lmt-swallow merged commit 9fcdef2 into main Sep 29, 2021
@lmt-swallow lmt-swallow deleted the chore/performance-improvement branch September 29, 2021 05:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants