Skip to content
This repository was archived by the owner on Jul 23, 2025. It is now read-only.

Refactor TreeMatcher #84

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Refactor TreeMatcher #84

merged 3 commits into from
Sep 29, 2021

Conversation

lmt-swallow
Copy link
Member

@lmt-swallow lmt-swallow commented Sep 28, 2021 •
edited
Loading

Description

N/A

Checklist

  • I opened a draft PR or added the [WIP] to the title if my PR is not ready for review.
  • I have reviewed the code by myself.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests enough to show how your code behaves and that your code works as expected.

Additional Notes

N/A

@lmt-swallow
wip: add notes on matching algorithm
a5e6e32 
Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@lmt-swallow lmt-swallow added the type: refactor Improvement of implementations label Sep 28, 2021
@lmt-swallow lmt-swallow self-assigned this Sep 28, 2021
@netlify
Copy link

netlify bot commented Sep 28, 2021 •
edited
Loading

✔️ Deploy Preview for cranky-fermi-e6c846 canceled.

🔨 Explore the source changes: 0e10cf9

🔍 Inspect the deploy log: https://app.netlify.com/sites/cranky-fermi-e6c846/deploys/6153ddb8c2927800071fafb2

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021 •
edited
Loading

Codecov Report

Merging #84 (0e10cf9) into main (a8ce606) will increase coverage by 0.10%.
The diff coverage is 84.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   74.52%   74.62%   +0.10%     
==========================================
  Files          26       26              
  Lines        1413     1411       -2     
==========================================
  Hits         1053     1053              
+ Misses        360      358       -2
Impacted Files Coverage Δ
src/core/query.rs 100.00% <ø> (ø)
src/core/tree.rs 90.56% <66.66%> (+6.98%) ⬆️
src/core/matcher/tree.rs 83.33% <77.96%> (-3.45%) ⬇️
src/core/language/docker.rs 99.07% <88.88%> (-0.93%) ⬇️
src/core/language.rs 73.07% <100.00%> (ø)
src/core/language/go.rs 100.00% <100.00%> (ø)
src/core/language/hcl.rs 95.95% <100.00%> (+0.04%) ⬆️
src/core/node.rs 73.01% <100.00%> (+5.09%) ⬆️
src/core/transform.rs 73.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ce606...0e10cf9. Read the comment docs.

@lmt-swallow
wip: add some more notes
0e10cf9 
Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@lmt-swallow lmt-swallow marked this pull request as ready for review September 29, 2021 03:30
@lmt-swallow lmt-swallow merged commit 0fb512d into main Sep 29, 2021
@lmt-swallow lmt-swallow deleted the feature/refactor-matcher branch September 29, 2021 03:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@lmt-swallow lmt-swallow

Labels
type: refactor Improvement of implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmt-swallow @codecov-commenter