Skip to content
This repository was archived by the owner on Jul 23, 2025. It is now read-only.

Support multiple character encodings #72

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Support multiple character encodings #72

merged 2 commits into from
Sep 22, 2021

Conversation

lmt-swallow
Copy link
Member

@lmt-swallow lmt-swallow commented Sep 22, 2021 •
edited
Loading

Description

This PR enables Shisho to handle character encodings other than UTF-8.

Checklist

  • I opened a draft PR or added the [WIP] to the title if my PR is not ready for review.
  • I have reviewed the code by myself.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests enough to show how your code behaves and that your code works as expected.

Additional Notes

N/A

@lmt-swallow
feat: add multiple encoding supports
06e5f0b 
Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@lmt-swallow lmt-swallow self-assigned this Sep 22, 2021
@netlify
Copy link

netlify bot commented Sep 22, 2021 •
edited
Loading

✔️ Deploy Preview for cranky-fermi-e6c846 canceled.

🔨 Explore the source changes: 14011c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/cranky-fermi-e6c846/deploys/614b17985bede80007db20e6

@lmt-swallow
chore: add e2e tests for encoding support
14011c6 
Signed-off-by: Takashi Yoneuchi <takashi.yoneuchi@shift-js.info>
@lmt-swallow lmt-swallow merged commit 8160a76 into main Sep 22, 2021
@lmt-swallow lmt-swallow deleted the feature/support-multiple-encoding branch September 22, 2021 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@lmt-swallow lmt-swallow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lmt-swallow