Forward validator registrations without decoding #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
reviewed
Feb 11, 2025
ralexstokes
previously approved these changes
Feb 11, 2025
There was a problem hiding this comment.
the code generally looks good. some notes:
- there are no tests for this AFACIT, we should test somehow before putting into a release
- there is a change in behavior here where mev-boost no longer verifies the validator registrations deserialize correctly; it should be fine (the relay will still do this, etc) but is somewhat of a notable change
- im not going all of the go APIs with a fine-toothed comb, so could be missing something with error handling, request processing, etc
Agreed. I've pushed some basic tests to ensure the forwarding works as expected.
Also agreed. But I feel that this is fine. The builder/relay should check this. Keep in mind it's possible for clients to connect directly to a single builder/relay and skip the mev-boost middleman. Meaning they need to handle bad inputs too. |
metachris
approved these changes
Feb 13, 2025
jtraglia
added a commit
that referenced
this pull request
Apr 22, 2025
* v1.8.2-dev * fix CONTRIBUTING lint path (#683) * Update linters and fix issues (#707) * Update main.go (#706) * chore: add `.env.example` (#696) * chore(git): add *.env, !.env.example to .gitignore * chore: .env.example * docs: fix invalid link in the document (#690) * Release the RISC-V binary. (#682) Part of #681. * Add support for Electra (#651) * Replace go-*-client deps with electra forks * Add processElectraPayload * Run make fmt * Replace Exits with WithdrawRequests * Rename WithdrawRequest to WithdrawalRequest * Run go mod tidy * Use go-*-client@electra * Upgrade go-eth2-client * update deps * Add t.Helper() call * Add back nolint comment * Replace attestantio/go-*-client deps * Fix accidental change * Update go-boost-utils * Update go-eth2-client for alpha.7 support * Fix mistake * Update & reverse payload decoding order * Revert decoding order & add replacements * Update go-eth2-client * Update go-builder-client * Modify processElectraPayload to use a channel (#704) * server: refactor processElectraPayload (#703) * Update go-eth2-client to latest electra commit * Remove nolint:canonicalheader comments * Disable canonicalheader linter --------- Co-authored-by: avalonche <avalonche@protonmail.com> Co-authored-by: Tyler <122291810+0xTylerHolmes@users.noreply.github.com> * Update golang to 1.23 (#717) * Update linter tools (#718) * Update dependencies (#716) * Update go-ethereum to v1.14.13 * Update go-utils to v0.8.3 * Update uint256 to v1.3.2 * Update testify to v1.10.0 * Update urfave/cli/v3 to v3.0.0-beta1 * Update go-bitfield to v0.0.0-20240618144021-706c95b2dd15 * Bump golang.org/x/crypto from 0.23.0 to 0.31.0 (#714) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.23.0 to 0.31.0. - [Commits](golang/crypto@v0.23.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Minor cleanup (#715) * server: refactor bidRespKey * server: split http handling and functionality * Fix versionFlag to output to stdout (#710) * Fix versionFlag to output to stdout * Write version with fmt.Fprintf(cmd.Writer, ...) --------- Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Co-authored-by: Justin Traglia <jtraglia@pm.me> * server: split http handling and functionality (part2) (#721) * server: split out logger preparation (#722) * server: make processPayload generic (#723) * server: re-add capella types (#724) * server: re-add capella types * Remove unnecessary type arguments * Add missing verifyBlockhash for electra --------- Co-authored-by: Justin Traglia <jtraglia@pm.me> * server: re-add bellatrix support (#725) * server: re-add bellatrix support * Remove unnecessary type arguments * server: refactor TestGetPayloadFork tests (#726) * server: refactor getPayloadForks tests * server: remove old tests * server: add nolint directive * server: remove duplicate tests * server: tiny refactor * server: tiny refactor * server: tiny refactor * server: refactor tests again * Rename denebHeader & add comment --------- Co-authored-by: Justin Traglia <jtraglia@pm.me> * Fix various nits (#728) * Make error message better * Use phase0.Slot type for slots * Do a little clean up in service * Rename "_slot" to "slot" * Clean up getHeader function * Do some clean up in functionality * Split functionality.go into get_{header,payload}.go (#730) * Use consistent capitalization for log messages (#732) * Add fixes to SendHTTPRequest (#735) * add missing error check * move error check and use the same format for header comments * Bump github.com/ethereum/go-ethereum from 1.14.13 to 1.15.0 (#737) Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.14.13 to 1.15.0. - [Release notes](https://github.com/ethereum/go-ethereum/releases) - [Commits](ethereum/go-ethereum@v1.14.13...v1.15.0) --- updated-dependencies: - dependency-name: github.com/ethereum/go-ethereum dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Forward validator registrations without decoding (#733) * Bump github.com/ethereum/go-ethereum from 1.15.0 to 1.15.1 (#740) Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.15.0 to 1.15.1. - [Release notes](https://github.com/ethereum/go-ethereum/releases) - [Commits](ethereum/go-ethereum@v1.15.0...v1.15.1) --- updated-dependencies: - dependency-name: github.com/ethereum/go-ethereum dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add SSZ tests for registerValidator (#741) * Add SSZ tests for registerValidator * Simplify conditional * Fix a flakey test * Remove support for relay monitors (#739) * Remove support for relay monitors * Remove blocknative relay from example * Add getHeader SSZ support (#734) * docs: fix Rémy Roy's guide link in README.md (#744) * docs: fix Rémy Roy's guide link in README.md * Update README.md Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> --------- Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Bump github.com/ethereum/go-ethereum from 1.15.1 to 1.15.2 (#743) Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.15.1 to 1.15.2. - [Release notes](https://github.com/ethereum/go-ethereum/releases) - [Commits](ethereum/go-ethereum@v1.15.1...v1.15.2) --- updated-dependencies: - dependency-name: github.com/ethereum/go-ethereum dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/attestantio/go-builder-client (#745) * Add HeaderDateMilliseconds for improved request timing tracking (#748) - Introduce new HeaderDateMilliseconds constant in constants.go - Add HeaderDateMilliseconds to getHeader and processPayload methods - Mark HeaderStartTimeUnixMS as deprecated with a comment * Update dependencies (#755) * Upgrade to go 1.24 * Update dependencies * Update linters & fix complaints * Update go versions elsewhere * Add Hoodi testnet flag (#758) * Add hoodi flag to the CLI * Update docs * Add getPayload SSZ support (#742) * Start to add getPayload SSZ support * Add log for failed content parsing * Update go-builder-client * Properly parse getPayload response content type * s/relaysToRequestFrom/relays * Do a single SSZ to JSON conversion if necessary * Only use JSON if necessary * Simplify * Only do conversion if necessary * Bump version to v1.9-rc3 (#759) * Remove deprecated HeaderStartTimeUnixMS (#749) - Remove HeaderStartTimeUnixMS constant from constants.go - Remove HeaderStartTimeUnixMS from getHeader and processPayload methods - Fully transition to using HeaderDateMilliseconds for request timing Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> * Add more logging to registerValidator (#768) * fix: JSON Content-Type for relay get payload w/o SSZ support (#769) * Update linters (#772) * Update linters & migrate golangci-lint config * Fix linter errors * Update all dependencies (#771) * Update version to v1.9 (#775) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Chris Hager <chris@linuxuser.at> Co-authored-by: Jonas Warlike <mikmillarog@gmail.com> Co-authored-by: Tyler <122291810+0xTylerHolmes@users.noreply.github.com> Co-authored-by: richard <ohko4711@163.com> Co-authored-by: Lorenzo <lorenzo.feroleto.dev@gmail.com> Co-authored-by: guckool <yingzhengcrypto@gmail.com> Co-authored-by: Leonardo Arias <leo@flashbots.net> Co-authored-by: avalonche <avalonche@protonmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: coincashew <62976495+coincashew@users.noreply.github.com> Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> Co-authored-by: Alexander Tesfamichael <alex.tesfamichael@gmail.com> Co-authored-by: Jacob Kaufmann <jacobkaufmann18@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
register_validator.gofile.wrapUserAgentmethod.✅ I have run these commands
make lintmake test-racego mod tidy