Skip to content

cmd/mev-boost: add urfave as cli framework #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 5, 2024
Merged

cmd/mev-boost: add urfave as cli framework #660

merged 6 commits into from
Aug 5, 2024

Conversation

MariusVanDerWijden
Copy link
Collaborator

📝 Summary

This PR adds urfave/cli as a cli framework and reworks some of the logic in the main package.
It also gets rid of the weird redirections into the cli package

⛱ Motivation and Context

Cleanup, adds a cli framework which makes adding flags easier in the future

@MariusVanDerWijden
Copy link
Collaborator Author

closes #640

@metachris
Copy link
Collaborator

Cool, thanks! A few quick notes

  • The "weird indirection" was to allow go install github.com/flashbots/mev-boost (it won't work without a root main.go file i think)
  • I like urfave a lot, and the cli flags have grown significantly and unpleasantly in mev-boost. But is the switch to urfave backwards-compatible, or would it break? This seems to be a major concern, if the upgrade would force all proposers to update their cli flags.

jtraglia
jtraglia previously approved these changes Jul 24, 2024
View reviewed changes
@metachris
Copy link
Collaborator

@MariusVanDerWijden can you please add the root main.go file back, so go install github.com/flashbots/mev-boost works?

@metachris metachris mentioned this pull request Jul 24, 2024
Closed
@metachris metachris merged commit 447923c into flashbots:develop Aug 5, 2024
@metachris metachris mentioned this pull request Aug 5, 2024
Merged
3 tasks
@metachris metachris mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metachris metachris metachris approved these changes

@jtraglia jtraglia jtraglia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MariusVanDerWijden @metachris @jtraglia