fix: clickhouse panic #1263
Merged
fix: clickhouse panic #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a panic in the ClickHouse input module by preventing index out of bounds errors when executing custom queries. The fix ensures safe connection distribution when the number of custom metrics exceeds the number of available connections.
- Adds a safety check to return early when no connections are available
- Implements modulo-based connection distribution to prevent array index overflow
- Updates log level from error to informational for metrics count logging
inputs/clickhouse/clickhouse.go
Outdated
| @@ -187,15 +187,21 @@ func (ins *Instance) Gather(slist *types.SampleList) { | |||
| log.Println("E! failed to exec query commonMetrics error:", err) | |||
| } | |||
| } | |||
| log.Println("E!metrics=", len(ins.Metrics)) | |||
| log.Println("I!metrics=", len(ins.Metrics)) | |||
There was a problem hiding this comment.
[nitpick] Consider using structured logging instead of concatenating strings in log messages. For example: log.Printf("I! metrics count: %d", len(ins.Metrics))
Suggested change
| log.Println("I!metrics=", len(ins.Metrics)) | |
| log.Printf("I! metrics count: %d", len(ins.Metrics)) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.