fix: The "network" field in the heartbeat reported data is null in a Windows 10 environment. #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个环境network为什么是null ? |
|
out, err := exec.Command("ipconfig", "-all").CombinedOutput() 在Windows 10 中文版本，out输出是gbk编码，导致go解析乱码。 |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where the "network" field in the heartbeat reported data was null in a Windows 10 environment by updating the command execution process.
- Executes "chcp 65001 >nul && ipconfig /all" via cmd to force UTF-8 encoding before running ipconfig.
- Changes the exec.Command usage to a shell command invocation.
Comment on lines
+16
to
19
| cmd := exec.Command("cmd", "/c", "chcp 65001 >nul && ipconfig /all") | ||
| out, err := cmd.CombinedOutput() | ||
| if err != nil { | ||
| return |
There was a problem hiding this comment.
Combining the 'chcp' and 'ipconfig' commands with '&&' may obscure which command failed; consider separating these commands to improve error diagnostics.
Suggested change
| cmd := exec.Command("cmd", "/c", "chcp 65001 >nul && ipconfig /all") | |
| out, err := cmd.CombinedOutput() | |
| if err != nil { | |
| return | |
| // Execute the chcp command to set the code page to UTF-8 | |
| chcpCmd := exec.Command("cmd", "/c", "chcp 65001 >nul") | |
| if err := chcpCmd.Run(); err != nil { | |
| return nil, errors.New("failed to execute chcp command: " + err.Error()) | |
| } | |
| // Execute the ipconfig command to retrieve network information | |
| ipconfigCmd := exec.Command("cmd", "/c", "ipconfig /all") | |
| out, err := ipconfigCmd.CombinedOutput() | |
| if err != nil { | |
| return nil, errors.New("failed to execute ipconfig command: " + err.Error()) |
Copilot uses AI. Check for mistakes.
|
Thank you @openownworld |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "network" field in the heartbeat reported data is null in a Windows 10 environment.