Skip to content

drop python 3.8 #3560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2024
Merged

drop python 3.8 #3560

merged 3 commits into from
Nov 8, 2024

Conversation

helpmefindaname
Copy link
Member

@helpmefindaname helpmefindaname commented Oct 25, 2024 •
edited
Loading

Since python3.8 is no longer supported, we can now drop it and use python3.9 features in our code, especially improving typing.

This pr does:

  • increase the minimum python version to 3.9 and uses it in gh-actions
  • update ruff to version 0.7 & fixes new linting errors
  • uses the python3.9 typing features
  • removes some methods that aren't used since longer
  • ensure that transformer embeddings will stay with the attention implementation that were saved, preventing precision issues after reloading.

@alanakbik alanakbik merged commit 7eb8533 into master Nov 8, 2024
1 check passed
@alanakbik alanakbik deleted the drop_python3.8 branch November 8, 2024 11:38
@alanakbik
Copy link
Collaborator

@helpmefindaname thanks a lot for the PR!

@jeffpicard jeffpicard mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanakbik alanakbik alanakbik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helpmefindaname @alanakbik