Update mypy #3210
Merged
Update mypy #3210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 21, 2023 22:05
By running: pipx run no_implicit_optional flair pipx run no_implicit_optional tests Following: https://github.com/hauntsaninja/no_implicit_optional
750fdd7 to
8677c62
Compare
|
@Lingepumpe thanks for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/!\ PR contains autogenerated code, please review the commits individually, the automatic adjustments are confined to the last commit /!\
Currently we have a old version of mypy pinned in requirements-dev. This is because after mypy 0.982, the "implicit Optional" was removed, so you can no longer do "x: int = None", you must do "x: Optional[int] = None". This produces lots of errors to fix, but there is a tool that mypy recommends to automatically fix your codebase, which I applied in this PR:
https://github.com/hauntsaninja/no_implicit_optional