Skip to content

GH-3250: Save final model only if save_final_model is True (even if the training is interrupted) #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2023
Merged

GH-3250: Save final model only if save_final_model is True (even if the training is interrupted) #3251

merged 1 commit into from
Aug 8, 2023

Conversation

plonerma
Copy link
Collaborator

ModelTrainer should only save final-model.pt if the respective flag is True (regardless of the reason the training ended (see #3250).

@alanakbik
Copy link
Collaborator

Makes sense! Thanks for adding this @plonerma!

@alanakbik alanakbik merged commit b18aff2 into master Aug 8, 2023
@alanakbik alanakbik deleted the GH-3250-save_final_model branch August 8, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plonerma @alanakbik