Skip to content

fix seralization of config in transformers #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix seralization of config in transformers #3178

merged 1 commit into from
Mar 31, 2023

Conversation

helpmefindaname
Copy link
Member

I noticed that transformer embeddings download the config from the hub whenever they are loaded.
This PR fixes that.

Example to run on master:

from flair.models import SequenceTagger

tagger = SequenceTagger.load("ner-large")
tagger.save("ner-large.pt")

# now delete the huggingface cache and disable internet, before running the code below

reloaded_tagger = SequenceTagger.load("ner-large.pt")
# this will fail on master but not on this branch

@alanakbik
Copy link
Collaborator

@helpmefindaname thanks for spotting and fixing this!

@alanakbik alanakbik merged commit 534d479 into master Mar 31, 2023
@alanakbik alanakbik deleted the fix_config_seralization_of_transformers branch March 31, 2023 11:09
@alanakbik
Copy link
Collaborator

@helpmefindaname I believe this introduces a new error. If I run:

from flair.models import MultitaskModel

linker = MultitaskModel.load('zelda')

I now get the following error:

TypeError: __init__() got an unexpected keyword argument 'truncate'

@alanakbik alanakbik mentioned this pull request Apr 27, 2023
Closed
@helpmefindaname helpmefindaname mentioned this pull request Apr 28, 2023
Merged
@helpmefindaname helpmefindaname mentioned this pull request Jun 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helpmefindaname @alanakbik