more precise type hint for eval_on_train_fraction #2811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The train() method of trainer.py accepts an eval_on_train_fraction parameter, with either a float or "dev" literal string value (see docstring). This commit adds the "dev" literal option to the type hint.
|
Looks like Literal type hint is only available from python 3.8 but the tests run on 3.7. I guess we can get back to this when 3.7 support is dropped, and maybe add a plain |
The train() method of trainer.py accepts an eval_on_train_fraction parameter, with either a float or "dev" literal string value (see docstring). This commit adds the string option to the type hint. Once python 3.7 is dropped, this can be changed to the even more precise "dev" Literal, see: c1791f0
|
@thlor thanks for adding this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The train() method of trainer.py accepts an eval_on_train_fraction parameter, with either a float or "dev" literal string value (see docstring). This commit adds the "dev" literal option to the type hint.