-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Description
Feature Description
Hello,
kimageformats package contains optional support of HEIF/HEIC format.
However, following piece of code prevents to use it:
flameshot/src/utils/screenshotsaver.cpp
Line 72 in 3ededae
if (mimeType != "image/heif") { |
I understand what is the intention. Macheif plug-in from Qt declare it supports both image/heic
and image/heif
mime types.
Technically the image/heic
is the same (alias) as image/heif
and it leads in glitch in save dialog, because the entry is doubled.
For this reason, the plugin from kimageformats declares support only for image/heif
and not for the alias. Unfortunately, the image/heif
mime type is filtered out by the flameshot code in screenshotsaver.cpp and the plugin from kimageformats is not used as result.
I guess it would be better to filter image/heic
alias instead of image/heif
BTW, there is also another HEIF plug-in for Qt. It uses also other aliases: https://github.com/jakar/qt-heif-image-plugin/blob/master/src/heif.json
I suggest to filter aliases (image/heic, image/heic-sequence, image/heif-sequence) but to leave main image/heif
unfiltered.