Skip to content

Accept % as first scalar character #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Sep 22, 2024

The current deserializer doesn't properly handle the '%' character based on whether it processes document directives or contents.
As the spec specifies here, if it processes document directives, '%' as the first character should be interpretted as the beginning of a directive; and if it processes document contents, '%' can be used as the first character of a scalar:

%YAML 1.2
---
%this key: is valid # the first '%' is not the beginning of a directive

So, this PR has modified the lexer so it can properly decide whether '%' is the beginning of a directive or the first character of a scalar.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Sep 22, 2024
@fktn-k fktn-k added this to the Release v0.3.13 milestone Sep 22, 2024
@fktn-k fktn-k self-assigned this Sep 22, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit f47e3ac0b200f3261e2a6e8a478abf68819e7a2b.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr399.zip
ID 1963553566
URL https://github.com/fktn-k/fkYAML/actions/runs/10983240173/artifacts/1963553566

@fktn-k fktn-k merged commit 33f8a41 into develop Sep 22, 2024
165 checks passed
@fktn-k fktn-k deleted the accept_%_as_first_scalar_character branch September 22, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant