Skip to content

Refine benchmarking #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 22, 2024
Merged

Refine benchmarking #397

merged 5 commits into from
Sep 22, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Sep 22, 2024

This PR has refined the benchmarking tool and data files some of which are incorporated from the miroyip/nativejson-benchmark repository.
Also, rapidyaml used there has been updated from 0.6.0 to 0.7.0 which includes huge parser improvements, and rapidyaml usages with mutable buffers have been fixed (I didn't fully understand how it worked at the time I introduced the tool).


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added documentation Improvements or additions to documentation improvement refactoring or optimization without public API changes labels Sep 22, 2024
@fktn-k fktn-k added this to the Release v0.3.13 milestone Sep 22, 2024
@fktn-k fktn-k self-assigned this Sep 22, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 90ac1ff7034613b7515fffd58bb0b59015ba6fff.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr397.zip
ID 1962587629
URL https://github.com/fktn-k/fkYAML/actions/runs/10978133486/artifacts/1962587629

@fktn-k fktn-k merged commit f79b58c into develop Sep 22, 2024
94 checks passed
@fktn-k fktn-k deleted the refine_benchmarking branch September 22, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant