-
Notifications
You must be signed in to change notification settings - Fork 15
Reduce string copies in parse #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_string_view since C++17)
|
Name | fkYAML_coverage.pr394.zip |
---|---|
ID | 1957793065 |
URL | https://github.com/fktn-k/fkYAML/actions/runs/10958197573/artifacts/1957793065 |
1d2b10d
to
fb03d72
Compare
b7c70b4
to
5f3e803
Compare
743e97e
to
014b1d3
Compare
014b1d3
to
feb0187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has significantly reduced the number & size of string copies and subsequent heap allocations during parsing of YAML sources by the following major changes:
fkyaml::detail::str_view
class which is newly implemented as a minimal implementation ofstd::string_view
(since C++17) even when the library is built with C++11 or C++14 so that inspections into YAML sources are executed more effectivelystd::string
object if they don't contain CR newline codes and are an array/container which has contiguous byte array to store actual characters (likechar [N]
,std::vector
orstd::string
)std::string
instanciations during the parsingAs a result of the above changes, the benchmark scores of this library has increased by 0.5MiB/s (when parsing tool/benchmark/macos.yml file with the same environment described in README.md):
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.