Skip to content

Parse +.inf as the positive float infinity #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Sep 8, 2024

The current parser recognize "+.inf", "+.Inf" and "+.INF" as a string scalar, but the spec explicitly defines them as part of positive float infinity writings.
To fix the above issue, this PR has corrected the way of scanning scalar contents and converting them into the positive float infinity.
Some test cases have also been added to validate the updated implementation.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Sep 8, 2024
@fktn-k fktn-k added this to the Release v0.3.12 milestone Sep 8, 2024
@fktn-k fktn-k self-assigned this Sep 8, 2024
Copy link

github-actions bot commented Sep 8, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit b6b2a76dfbbc21be4c70ad47a785468d728a40e4.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr393.zip
ID 1905634033
URL https://github.com/fktn-k/fkYAML/actions/runs/10758050373/artifacts/1905634033

@fktn-k fktn-k merged commit a6938f6 into develop Sep 8, 2024
165 checks passed
@fktn-k fktn-k deleted the fix_parse_positive_infinity_with_plus branch September 8, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant