Skip to content

Fix detecting invalid contents of block scalar headers #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Aug 31, 2024

The current library can't detect invalid contents specified in block scalar headers, like the followings:

foo: |10 # the indentation must be between 1 and 9.
foo: >++ # too many chomping indicators
foo: |invalid # neither chomping nor indentation indicators must be a comment.

So, this PR has fixed the implementation for parsing block scalar headers and also added some relevant test cases.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Aug 31, 2024
@fktn-k fktn-k added this to the Release v0.3.12 milestone Aug 31, 2024
@fktn-k fktn-k self-assigned this Aug 31, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 2d06a3ebc40ba57ddd3e3e53ceb443bacfb95ed9.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr387.zip
ID 1877686395
URL https://github.com/fktn-k/fkYAML/actions/runs/10644770003/artifacts/1877686395

@fktn-k fktn-k merged commit 458ac8b into develop Aug 31, 2024
165 checks passed
@fktn-k fktn-k deleted the detect_invalid_indent_given_in_block_scalar_header branch August 31, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant