Skip to content

Improve UTF encoding detection #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 31, 2024
Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Aug 31, 2024

This PR has improved implementations for UTF encoding detection by separating detector impl classes accordingly to the given char type or by reducing an unnecessary number of array element accesses during the detection.
No changes should appear to the library users since this is just a refactoring.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Aug 31, 2024
@fktn-k fktn-k added this to the Release v0.3.12 milestone Aug 31, 2024
@fktn-k fktn-k self-assigned this Aug 31, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 4de50418e5b5abf526e361fab6ebc9c57cbdde0b.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr386.zip
ID 1877267691
URL https://github.com/fktn-k/fkYAML/actions/runs/10642502395/artifacts/1877267691

@fktn-k fktn-k merged commit 293fdd1 into develop Aug 31, 2024
165 checks passed
@fktn-k fktn-k deleted the improve_utf_encode_detection branch August 31, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant