Skip to content

Fix workflow errors on PRs from fork repos #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Aug 22, 2024

With this PR, I try to fix workflow errors on a PR from a fork repository since some workflows need to write permission to the PR or acceess to secrets to push an automatically created commit.
One way to resolve them is change the trigger event from pull_request to pull_request_target, just as this PR does.
Note, according to the official document, that can be insecure against stealing secrets or running a malicious code.
So, further changes will be required to increase security in the future since this is first aid to the errors.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

…mat/coverage workflows for PRs from fork repos
@fktn-k fktn-k added the ci related to CI jobs label Aug 22, 2024
@fktn-k fktn-k added this to the Release v0.3.11 milestone Aug 22, 2024
@fktn-k fktn-k self-assigned this Aug 22, 2024
@fktn-k fktn-k merged commit 2d17c1c into develop Aug 22, 2024
3 checks passed
@fktn-k fktn-k deleted the fix_ci_error_on_pr_from_fork_repos branch August 22, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci related to CI jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant